-
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added privacy considerations note.
- Loading branch information
Showing
1 changed file
with
20 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,26 @@ SponsorLink supports two scenarios: | |
|
||
[Read the announcement](https://www.cazzulino.com/sponsorlink.html) blog post. | ||
|
||
## Privacy Considerations | ||
|
||
There was some concern that SponsorLink might be collecting your email without your | ||
explicit consent. This is incorrect, and can easily be verified by running Fiddler | ||
to see what kind of traffic is happening. | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ChrisMcKee
|
||
|
||
Specifically, the actual email is never sent when performing the sponsoring check. | ||
The email on your local machine is hashed with SHA256, then Base62-encoded. The | ||
resulting opaque string (which can never reveal the originating email) is the only | ||
thing used. | ||
|
||
The only moment SponsorLink actually gets your email address (to perform the backend- | ||
side association of that opaque string with your actual email and GH user to link | ||
your sponsorship), is *after* you install the [SponsorLink GitHub app](https://github.com/apps/sponsorlink) | ||
and give it explicit permission to do so. | ||
|
||
Also, the moment you suspend or uninstall the app, we delete all records associated | ||
with your account and your email(s). | ||
|
||
|
||
##  Open source developers | ||
|
||
[GitHub Sponsors](https://github.com/sponsors) provides the core functionality to | ||
|
1 comment
on commit a199a4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Statement clearly shows you are aware of the issue and not intent on resolving it. Reported to NuGet as malware and security vulnerability.
It's not totally incorrect, you can compare those hashes against set of mails leaked somewhere else and this way identify me. I consider your hashing more as a security by obscurity. Even hashed mail should be sent only after consent.