-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configured Detekt for Static Analysis & Code Quality #1071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
niyajali
commented
Aug 26, 2024
- Close Configure Detekt for Static Analysis & Code Quality #1070
This commit replaces the dependency guard check with detekt in the build workflow.
This commit updates the `ScaffoldNavActions` and `ExportScaffold` components to use `Row` instead of `Column` for layout. The `tests_and_lint` workflow is also updated to depend on the `screenshot_tests` workflow. This ensures that screenshot tests are run before tests and lint checks.
This commit introduces a new workflow that automatically fixes formatting issues if the detekt verification fails. The workflow uses the `spotlessApply` gradle task to apply formatting changes and then pushes the changes using the `git-auto-commit-action`.
This commit updates the CI workflow to use spotless for fixing formatting issues if verification fails. The previous workflow used detekt for this purpose, but spotless is a more appropriate tool for this task.
Combined test coverage report
Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.