Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement & Fix - Address Screen #1015

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Enhancement & Fix - Address Screen #1015

merged 4 commits into from
Aug 5, 2024

Conversation

- Close #1010
- Close #1011
- Close #1012
- Close #1013
- Close #1014
Copy link
Member Author

@niyajali niyajali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, can merge with base branch and close this PR.

- Removed API 26 from the CI matrix, now only running tests and checks on API 30.
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Combined test coverage report

Overall Project 22.44% -0.64%
Files changed 32.44%

Module Coverage
addonitem 74.67% -1.45% 🍏
address 68.27% -0.94% 🍏
market 36.69% -0.1%
domain 8.42% -4.55%
ui 0.5% -3.57%
common 0% -4.63%
designsystem 0% -0.13%
Files
Module File Coverage
addonitem AddOnSettingsViewModel.kt 91.24% -1.59% 🍏
AddEditAddOnItemViewModel.kt 88.57% 🍏
AddOnExportScreen.kt 68.67% -1.09% 🍏
AddOnImportScreen.kt 63.83% -8.67% 🍏
address AddEditAddressEvent.kt 100% 🍏
AddEditAddressState.kt 100% 🍏
AddressSettingsEvent.kt 100% 🍏
AddressDetailsViewModel.kt 97.23% 🍏
AddEditAddressViewModel.kt 90.39% 🍏
AddressSettingsViewModel.kt 89.77% -1.86% 🍏
AddEditAddressScreen.kt 89.27% 🍏
AddressViewModel.kt 86.53% 🍏
AddressScreen.kt 80.61% -0.03% 🍏
AddressSettingsScreen.kt 80.03% 🍏
RecentOrders.kt 77.08% 🍏
AddressDetailsCard.kt 72.46% 🍏
AddressExportScreen.kt 69.19% -1.03% 🍏
ListOfOrders.kt 66.76% 🍏
AddressData.kt 65.77% 🍏
AddressImportScreen.kt 64.26% -8.05% 🍏
AddressDetailsScreen.kt 51.11% 🍏
GroupedOrders.kt 0% 🍏
market MeasureUnitSettingsViewModel.kt 0% -4.78%
MarketItemSettingsViewModel.kt 0% -4.7%
MarketTypeSettingsViewModel.kt 0% -4.78%
domain ValidateAddressNameUseCase.kt 100% 🍏
ValidateAddressShortNameUseCase.kt 100% 🍏
ImportExport.kt 0% -23.4%
ui BaseViewModel.kt 89.41% -2.12% 🍏
PoposDrawer.kt 0% -1.33%
PoposPrimaryScaffold.kt 0% -0.27%
ExportScaffold.kt 0% -91.91%
common Extensions.kt 0% -7.43%
designsystem PoposLargeTopAppBar.kt 0% -5.25%

@niyajali niyajali merged commit 0eb0e95 into main Aug 5, 2024
8 checks passed
@niyajali niyajali deleted the testing/address-testing branch August 5, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment