openamp-xlnx: Parse non-dedicated IPIs for OpenAMP channels #1
Conversation
As OpenAMP uses channel information to configure IPC, add the follwing: - sample ipi's in input system DT - parsing for ipis in openamp-xlnx assist - file generation in openamp-xlnx assist Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
assists/openamp-xlnx.py
Outdated
| @@ -24,6 +24,52 @@ | |||
| from lopper import Lopper | |||
| from lopper import LopperFmt | |||
| import lopper | |||
| from lopper_tree import * | |||
|
|
|||
| openamp_file_name = "openamp_lopper_gen.h" | |||
There was a problem hiding this comment.
Ben, Do we think that the filename might vary ? In that case, this can be the default and we could check the options dictionary in the assist callback for a filename. That way it could passed via a lop file and changed if needed.
There was a problem hiding this comment.
good point. added option to set file name via input r5 lop file in later commit
device-trees/system-device-tree.dts
Outdated
| @@ -54,6 +56,30 @@ | |||
| }; | |||
| }; | |||
| }; | |||
| ps_ipi_1 { | |||
There was a problem hiding this comment.
I recall feedback that if there's a reg property in the node, the name should include the unit address, i.e. https://elinux.org/Device_Tree_Usage#Node_Names
If so, should we add some @ to these ?
There was a problem hiding this comment.
added unit address to name in later commit.
Previously header file for openamp channel was hard-coded. Change to instead use file provided by input lop if specified Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
|
Hi Bruce, The latest commits should resolve your comments. Best Regards, |
|
merged! |
As OpenAMP uses channel information to configure IPC,
add the follwing:
Signed-off-by: Ben Levinsky ben.levinsky@xilinx.com