Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A zero cpu-mask means "all of them" #166

Open
mbolivar-nordic opened this issue Mar 2, 2023 · 1 comment
Open

A zero cpu-mask means "all of them" #166

mbolivar-nordic opened this issue Mar 2, 2023 · 1 comment

Comments

@mbolivar-nordic
Copy link
Contributor

As of 4fc81d4, the cpu-mask
property in the "openamp,domain-v1" binding says:

- *cpu-mask* is a bitfield indicating the subset of CPUs in the cluster which
  the domain runs on

I'd like to propose that we extend this binding to say that a value of
0 means that the domain runs on all of the CPUs in the cluster.

This seems like a common case and it is a useful shorthand which may
help users, especially since we could define a self-documenting macro
like DOMAIN_CPU_MASK_ALL for this.

@sstabellini
Copy link
Collaborator

I don't have a strong opinion on this one. I think that's OK either way. If you'd like to add it to the spec, I am OK with it.

mbolivar-nordic added a commit to mbolivar-nordic/lopper that referenced this issue May 10, 2023
Extend the execution domain binding to say that a cpu-mask cell value
of 0 means that the domain runs on all of the CPUs in the cluster.

This seems like a common case, and it is a useful shorthand which may
help users, who could define a self-documenting macro like
"DOMAIN_CPU_MASK_ALL" or so for this.

Fixes: devicetree-org#166
Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
Reviewed-by: Stefano Stabellini <stefano.stabellini@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants