Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: schemas: memory: describe the Qualcomm ddr_device_type property #121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lumag
Copy link

@lumag lumag commented Dec 15, 2023

The Qualcomm ABL bootloaders use the ddr_device_type property to describe the attached memory type.
We can not really change this bootloader on the end-user devices thanks to the SecureBoot. Certain drivers (display, GPU, video-encoding) need this information to properly program the hardware.
This PR attempts to document this property, while pointing out that its usage is limited to this particular bootloader, it should not be used by any other created designs and that its usage outside of the defined usecase is strictly forbidden.

Qualcomm bootloaders will patch the /memory@ node with the DDR memory
type property. The property name breaks defined standards and the
property is not compatible with the defined LPDDR schema. However given
that determining memory type is required by some drivers to properly
program the hardware and the bootloaders are deployed in a variety of
device which can not and will not be updated by the ODMs (because
significant amount of devices has reached EOL) and the users also can
not update the bootloader (thanks to the SecureBoot / bootloader
signatures), document this property to be used in this particular use
case only, not to be used manually etc.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
@lumag
Copy link
Author

lumag commented Dec 15, 2023

I understand that this is an example of a certain vendor breaking all possible standards. This is mostly an RFC to trigger the discussion on how we can cope with this particular case.

@robherring
Copy link
Member

Why is it important to you that this property not cause a warning? Just curious.

@lumag
Copy link
Author

lumag commented Dec 20, 2023

@robherring It's not the absense of a warning that is important to me. After getting this property documented I'd like to submit patches against soc/qcom and drm/msm that actually read and make use of that property for the purpose of setting up device correctly.

@konradybcio
Copy link

I propose we look at the thing that provides the data in this property instead.

@lumag
Copy link
Author

lumag commented Jan 26, 2024

I propose we look at the thing that provides the data in this property instead.

@konradybcio do you mean the bootloader? I do not expect that we can change ABL on end-user secured devices.

@konradybcio
Copy link

@lumag No, rather the place where that information comes from. I have something that resembles a PoC, but it's low prio for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants