Add target environment option #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevlened
commented
Jan 8, 2018
| @@ -13,6 +13,7 @@ prog | |||
| .option('--entry, -i', 'Entry module(s)') | |||
| .option('--output, -o', 'Directory to place build files into') | |||
| .option('--format, -f', 'Only build specified formats', 'es,cjs,umd') | |||
| .option('--target', 'Specify your target environment', 'node') | |||
There was a problem hiding this comment.
I use target, because that's the name in webpack. However, environment or platform may be more descriptive.
There was a problem hiding this comment.
I'm good with replicating webpack's naming there.
kevlened
commented
Jan 8, 2018
src/index.js
Outdated
| @@ -206,7 +206,8 @@ function createConfig(options, entry, format) { | |||
| }), | |||
| useNodeResolve && nodeResolve({ | |||
| module: true, | |||
| jsnext: true | |||
| jsnext: true, | |||
| browser: options.target === 'browser' | |||
There was a problem hiding this comment.
Can we just avoid the extra option and set browser: true always? If you're building for node, you'll use --external all anyway, so this will never be hit.
There was a problem hiding this comment.
I'd just do browser: options.target!=='node'.
developit
approved these changes
Jan 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building isomorphic libraries, it's useful to bundle browser versions of dependencies. The
targetoption makes this possible and provides flexibility to make environment-based decisions in the future.