Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Receiver Middleware #26

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

tsutomi
Copy link
Member

@tsutomi tsutomi commented Apr 26, 2023

The WebhookReceiverMiddleware design has been changed radically to support configurations and extensions

  • The WebhookReceiverMiddleware is now public and extensible (eg. to implement service-specific middleware, if needed)
  • The middleware is not anymore factory-based but rather convention-based: it allows specifying configuration options for the single instance, that can be extended by implementations of service-specific options
  • The options to handle the webhooks through the receiver middleware have been exported to another class, specific for the receiving operations.

@tsutomi tsutomi added the enhancement New feature or request label Apr 26, 2023
@tsutomi tsutomi self-assigned this Apr 26, 2023
@tsutomi tsutomi linked an issue Apr 26, 2023 that may be closed by this pull request
@tsutomi tsutomi merged commit 278c7e4 into main Apr 26, 2023
@tsutomi tsutomi deleted the 25-convention-based-receiver-middleware-extensions branch April 26, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convention-Based Receiver Middleware Extensions
1 participant