Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] 'Features' Distribution Specification #66

Merged
merged 12 commits into from
Jul 27, 2022
Merged

[Proposal] 'Features' Distribution Specification #66

merged 12 commits into from
Jul 27, 2022

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Jul 26, 2022 •
edited
Loading

relevant to: #7

  • Proposes OCI artifact registries as storage medium for features assets
  • Clarifies packaging and distribution steps
  • Clarifies several parts of the existing, general 'features' proposal

For historical discussion, see #40

@joshspicer joshspicer mentioned this pull request Jul 26, 2022
Closed
alexdima
alexdima approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left some minor comments.

proposals/devcontainer-features-distribution.md Outdated Show resolved Hide resolved
proposals/devcontainer-features-distribution.md Outdated Show resolved Hide resolved
proposals/devcontainer-features.md Outdated Show resolved Hide resolved
edgonmsft
edgonmsft approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@edgonmsft edgonmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samruddhikhandale
samruddhikhandale approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for writing this up ✨

jkeech
jkeech approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@jkeech jkeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a couple suggestions.

proposals/devcontainer-features-distribution.md Outdated Show resolved Hide resolved
proposals/devcontainer-features.md Outdated Show resolved Hide resolved
proposals/devcontainer-features.md Outdated Show resolved Hide resolved
proposals/devcontainer-features.md Outdated Show resolved Hide resolved
proposals/devcontainer-features.md Outdated Show resolved Hide resolved
joshspicer and others added 2 commits July 27, 2022 14:31
@joshspicer @jkeech
apply @jkeech suggestions
e7e3a6a 
Co-authored-by: John Keech <jokeech@microsoft.com>
@joshspicer
note about compatibility with base images
17cbfa5
@joshspicer joshspicer merged commit 29c3852 into main Jul 27, 2022
@joshspicer joshspicer deleted the distribution branch July 27, 2022 18:41
@edgonmsft edgonmsft mentioned this pull request Aug 1, 2022
Merged
This was referenced Aug 2, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamurtaugh bamurtaugh bamurtaugh left review comments

@edgonmsft edgonmsft edgonmsft approved these changes

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

@alexdima alexdima alexdima approved these changes

@jkeech jkeech jkeech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joshspicer @jkeech @alexdima @samruddhikhandale @bamurtaugh @edgonmsft