Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear NUGET_XMLDOC_MODE #941

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

eerhardt
Copy link
Contributor

Clear this environment variable so xml docs from NuGet packages are unpackaged. The default dotnet/sdk image sets it to 'skip'.

Without clearing this environment variable, the XML docs are not unpackaged and won't be used in intellisense.

See dotnet/dotnet-docker#2790

cc @radical @mthalman @MichaelSimons

Clear this environment variable so xml docs from NuGet packages are unpackaged. The default dotnet/sdk image sets it to 'skip'.

Without clearing this environment variable, the XML docs are not unpackaged and won't be used in intellisense.

See dotnet/dotnet-docker#2790
@eerhardt eerhardt requested a review from a team as a code owner January 31, 2024 21:32
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for taking the time to contribute! 🙏

@samruddhikhandale samruddhikhandale merged commit e8d0ebf into devcontainers:main Jan 31, 2024
2 checks passed
@eerhardt eerhardt deleted the patch-1 branch February 1, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants