Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart auto-install multiple versions for node #56

Merged
merged 12 commits into from
Jul 14, 2022

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Jun 29, 2022

Teaches node how to install itself multiple times.

Relevant to discussion at: devcontainers/spec#57

Tests?
Yes, validated via newly added test-scenarios

@joshspicer joshspicer changed the title node smart auto-install multiple versions smart auto-install multiple versions (for node/dotnet) Jun 29, 2022
@joshspicer joshspicer changed the title smart auto-install multiple versions (for node/dotnet) smart auto-install multiple versions for node Jun 30, 2022
@joshspicer joshspicer marked this pull request as ready for review June 30, 2022 01:35
@joshspicer joshspicer enabled auto-merge (squash) July 1, 2022 18:54
@samruddhikhandale samruddhikhandale enabled auto-merge (squash) July 11, 2022 21:45
Copy link
Contributor

@jungaretti jungaretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💸

check "v14_installed" ls -1 /usr/local/share/nvm/versions/node | grep 14.19.3
check "v17_installed" ls -1 /usr/local/share/nvm/versions/node | grep 17.9.1


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line

@@ -146,6 +150,25 @@ EOF
)"
fi

# Additional node versions to be installed but not be set as default.
if [ ! -z "${ADDITIONAL_VERSIONS}" ]; then

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line

@samruddhikhandale samruddhikhandale merged commit 01b46fa into main Jul 14, 2022
@samruddhikhandale samruddhikhandale deleted the jospicer/multiple_install_smart_features branch July 14, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants