-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
smart auto-install multiple versions for node
#56
Merged
samruddhikhandale
merged 12 commits into
main
from
jospicer/multiple_install_smart_features
Jul 14, 2022
Merged
smart auto-install multiple versions for node
#56
samruddhikhandale
merged 12 commits into
main
from
jospicer/multiple_install_smart_features
Jul 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshspicer
changed the title
node smart auto-install multiple versions
smart auto-install multiple versions (for Jun 29, 2022
node
/dotnet
)
Co-authored-by: Samruddhi Khandale <skhandale@microsoft.com>
joshspicer
changed the title
smart auto-install multiple versions (for
smart auto-install multiple versions for Jun 30, 2022
node
/dotnet
)node
samruddhikhandale
previously approved these changes
Jul 11, 2022
jungaretti
approved these changes
Jul 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💸
check "v14_installed" ls -1 /usr/local/share/nvm/versions/node | grep 14.19.3 | ||
check "v17_installed" ls -1 /usr/local/share/nvm/versions/node | grep 17.9.1 | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra line
@@ -146,6 +150,25 @@ EOF | |||
)" | |||
fi | |||
|
|||
# Additional node versions to be installed but not be set as default. | |||
if [ ! -z "${ADDITIONAL_VERSIONS}" ]; then | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teaches node how to install itself multiple times.
Relevant to discussion at: devcontainers/spec#57
Tests?
Yes, validated via newly added
test-scenarios