Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure common-utils rc snippets end with newlines #1100

Conversation

trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Aug 20, 2024

Adds line endings to common-utils' rc snippets after #1095.

This ensures any features appending to these files after installing common-utils don't produce mangled files.

what happens now:

$ echo "export foo=bar" >> ~/.bashrc
$ tail -n1 ~/.bashrc
fiexport foo=bar

what used to/should happen:

$ echo "export foo=bar" >> ~/.bashrc
$ tail -n1 ~/.bashrc
export foo=bar

Maybe also a good idea to add the following vscode settings to the repo's devcontainer.json (and/or encourage contributors to use these settings?):

    "files.insertFinalNewline": true,
    "files.trimFinalNewlines": true,
    "files.trimTrailingWhitespace": true,

@trxcllnt trxcllnt requested a review from a team as a code owner August 20, 2024 01:47
@trxcllnt trxcllnt changed the title Ensure common-utils rc snippets have line endings Ensure common-utils rc snippets end with empty lines Aug 20, 2024
trxcllnt added a commit to trxcllnt/devcontainers that referenced this pull request Aug 20, 2024
@trxcllnt trxcllnt changed the title Ensure common-utils rc snippets end with empty lines Ensure common-utils rc snippets end with newlines Aug 20, 2024
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants