Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

super-linterアップデート #4954

Closed
wants to merge 11 commits into from
Closed

Conversation

massongit
Copy link
Member

@massongit massongit commented Mar 8, 2025

#4901 をベースにsuper-linterをアップデートします。
以下も行っています。

  • n/no-unpublished-import に引っかからないよう、スクリプト内でimportしているパッケージを dependencies に移動

  • n/no-missing-import については解決が難しそうなので一旦無効化

  • textlint-rule-no-dead-linkによる https://ngrok.com/ のチェックを行うとsuper-linterの実行が終わらなくなるのでチェック対象から除外

  • 以下のWarning修正
    https://github.com/dev-hato/hato-bot/actions/runs/13733580708/job/38414470358#step:9:157

      2025-03-08 03:31:48 [WARN]   Git commit message validation with commitlint is enabled, but no commitlint configuration file is available. Disabling commitlint. To suppress this message, either disable Git commit validation by setting VALIDATE_GIT_COMMITLINT to false in your Super-linter configuration, or provide a commitlint configuration file.
      2025-03-08 03:31:48 [WARN]   TYPESCRIPT_DEFAULT_STYLE environment variable is set, it's deprecated, and super-linter will ignore it. Remove it from your configuration. This warning may turn in a fatal error in the future. For more information, see the upgrade guide: https://github.com/super-linter/super-linter/blob/main/docs/upgrade-guide.md
    

    https://github.com/dev-hato/hato-bot/actions/runs/13733580708/job/38414470358#step:9:598

      Warning: React version not specified in eslint-plugin-react settings. See https://github.com/jsx-eslint/eslint-plugin-react#configuration .
    

nodeをアップデートしてあげたよ! #4954
@massongit massongit marked this pull request as ready for review March 8, 2025 02:07
@massongit massongit requested a review from Goryudyuma March 8, 2025 02:08
@massongit massongit changed the title Update super linter 5 super-linterアップデート Mar 8, 2025
@massongit massongit removed the request for review from Goryudyuma March 8, 2025 03:29
@massongit massongit marked this pull request as draft March 8, 2025 03:29
@massongit massongit marked this pull request as ready for review March 8, 2025 03:42
@massongit massongit requested a review from Goryudyuma March 8, 2025 03:42
@massongit massongit closed this Mar 9, 2025
@massongit massongit deleted the update_super_linter_5 branch March 9, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant