Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed passing from as part of the overrides to contract call #350

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

krzkaczor
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2021

🦋 Changeset detected

Latest commit: 8528c8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@typechain/ethers-v5 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines +134 to +138
`overrides?: ${
contract.constructor[0]?.stateMutability === 'payable'
? 'PayableOverrides & { from?: string | Promise<string> }'
: 'Overrides & { from?: string | Promise<string> }'
}`
Copy link
Contributor

@quezak quezak Mar 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a

// TODO remove workaround for <ethers issue link>

(in our code, not in generated output)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants