Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying KeyC default. #848

Merged
merged 2 commits into from
Apr 13, 2024
Merged

Simplifying KeyC default. #848

merged 2 commits into from
Apr 13, 2024

Conversation

dessalines
Copy link
Owner

No description provided.

Copy link

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should save a lot of boilerplate code.

@dessalines
Copy link
Owner Author

Oh yeah. I'm just doing it for english thumbkey for now, but it could be done for a lot of keyboards.

@dessalines dessalines merged commit f708121 into main Apr 13, 2024
2 checks passed
@alerque
Copy link

alerque commented Apr 16, 2024

ChatGPT isn't a real programmer either, and that's almost complete gibberish.

This just makes in unnecessary to manually add a label to a key (the symbol displayed on the keyboard button) in the cases where the key action just outputs a single character. It just defaults the label to whatever the output character is. Now adding label properties to key definitions is only needed for more advanced actions or cases where the label doesn't match the thing being output, e.g. the enter key, arrow keys, special actions, etc.

Repository owner deleted a comment from MikeStirner Apr 16, 2024
@dessalines
Copy link
Owner Author

@MikeStirner do not post GPT prompts again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants