-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Keyboard layout English Spanish Catalan #826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…talan. Inspiration drawn from ES-CA thumbkey layout.
dessalines
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run ./gradlew formatKotlin
to pass lint.
app/src/main/java/com/dessalines/thumbkey/utils/KeyboardLayout.kt
Outdated
Show resolved
Hide resolved
I don't know what I'm doing with this, but I tried with the following failure.
|
It's alright, I'll fix the formatting issues shortly. |
dessalines
approved these changes
Apr 4, 2024
Thanks for adding my layout, and the help. I'll look forward to using it
when it reaches f-droid!
…On Thu, 4 Apr 2024, 19:31 Dessalines, ***@***.***> wrote:
Merged #826 <#826> into main.
—
Reply to this email directly, view it on GitHub
<#826 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7XGEJGXTLSYZDKXP4QMLY3WL7ZAVCNFSM6AAAAABFVC2LGGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGM3DEOJWGM2TANI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a layout based on English thumbkey layout supporting Spanish & Catalan. Inspiration drawn from ES-CA thumbkey layout.
I think I've done it right, but it's fairly unfamiliar stuff to me.
Reason for this layout is I already 'mapped' the English layout in my head but want to be able to type the Catalan and Spanish accents without stumbling.