-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MessagEase fixes #709
MessagEase fixes #709
Conversation
current EN keyboard
how I intend to fix it:
|
I think hang off on this, because I have a big PR in the works that revamps creation of keyboards like numeric |
app/src/main/java/com/dessalines/thumbkey/keyboards/NumericMessagEase.kt
Show resolved
Hide resolved
app/src/main/java/com/dessalines/thumbkey/keyboards/ESMessageEase.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dessalines/thumbkey/keyboards/ESMessageEase.kt
Outdated
Show resolved
Hide resolved
it looks like we have some very similar goals but we're approaching things differently. I'll look at your PRs, you should look at mine so we can coordinate |
I just checked #700 and I'm fully on board with what you're doing. This PR was intended as a "make my layout break my brain less right now" thing, it's a quick fix and it's already working (at least for what I desperately need in the very short term) |
app/src/main/java/com/dessalines/thumbkey/keyboards/ESMessageEase.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/dessalines/thumbkey/keyboards/ESMessageEase.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thx!
KeyC( | ||
display = KeyDisplay.TextDisplay("±"), | ||
action = KeyAction.CommitText("±"), | ||
color = ColorVariant.MUTED, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 4 symbols too please, annoying to have these disappear on me
I wanted to open the PR as fast as possible to centralize discussion here, please keep this PR open while I work on the following:
Related to this, I will also work (in another PR) on making "more symbols" variants for ES and EN keyboards, so people who like a super clean keyboard can have that and people like me who like a few more symbols at hand can have those