Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added emoji key to Type-Split layout. Fixes #432 #524

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Added emoji key to Type-Split layout. Fixes #432 #524

merged 1 commit into from
Oct 22, 2023

Conversation

sslater11
Copy link
Contributor

@sslater11 sslater11 commented Oct 21, 2023 •
edited
Loading

  • Added emoji key to the top row of all the type-split layouts.
  • Removed SPACEBAR_TYPESPLIT_ TOP_ _KEY_ITEM, and changed all references to point to the middle spacebar key.
  • Made SPACEBAR_TYPESPLIT_ _MIDDLE _KEY_ITEM its own KeyItemC, and not a copy of a KeyItemC
  • Moved the '*' symbol to the bottom left corner of the bottom space key.

thumbkey_typesplit

@sslater11 sslater11 requested a review from dessalines as a code owner October 21, 2023 21:06
dessalines
dessalines approved these changes Oct 22, 2023
View reviewed changes
Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx!

@dessalines dessalines merged commit bfcbd8b into dessalines:main Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sslater11 @dessalines