Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnglishV4MultiIT keyboard layout #449

Merged
merged 3 commits into from
Sep 29, 2023
Merged

EnglishV4MultiIT keyboard layout #449

merged 3 commits into from
Sep 29, 2023

Conversation

yuroller
Copy link
Contributor

I created a layout with Italian accented chars on the basis of the EnglishV4 layout.
It it similar to THUMBKEY_EN_V4_MULTI_KEYBOARD_MODES for SV language, but with Italian chars only.

Copy link
Owner

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx!

You need to run ./gradlew formatKotlin to pass lint.

@yuroller
Copy link
Contributor Author

After fixing the sorting of the import statements, shall I retire this pull request and do a new one or can I append a commit?
BTW: I just copy pasted the English Keyboard layout to a new file and made my modifications; maybe if there is the ability to apply a layer (e.g. italian accented chars) on top of an existing layout (e.g. englishV4), in the long run could make maintenance easier.

@dessalines
Copy link
Owner

You can add as many commits as you like to this PR.

BTW: I just copy pasted the English Keyboard layout to a new file and made my modifications; maybe if there is the ability to apply a layer (e.g. italian accented chars) on top of an existing layout (e.g. englishV4), in the long run could make maintenance easier.

Adding layers and conditionals to the definition files could get way too complicated too quickly. If there are any future bigger changes, you'll have to make a PR to edit the keyboard you just added.

@dessalines dessalines enabled auto-merge (squash) September 28, 2023 12:32
@dessalines dessalines merged commit f01bc1a into dessalines:main Sep 29, 2023
@yuroller yuroller deleted the multiIT branch September 29, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants