Fall cleanup #493
Fall cleanup #493
Conversation
| @@ -30,23 +36,23 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| with: | |||
| submodules: recursive | |||
| - name: Install Node.js ${{ matrix.arch }} | |||
| uses: niik/setup-node@f9547c97f4c519f71dc42e652d6d2c53f9527c1d | |||
There was a problem hiding this comment.
Didn't notice we used a custom setup-node 🤯
There was a problem hiding this comment.
Yeah, and from some super untrustworthy source too!
| if (process.stdout) { | ||
| process.stdout.on('data', chunk => { | ||
| if (chunk instanceof Buffer) { | ||
| stdout.push(chunk) | ||
| } else { | ||
| stdout.push(Buffer.from(chunk)) | ||
| } | ||
| }) | ||
| } |
There was a problem hiding this comment.
Can't we use optional chaining here? 🤔
| if (process.stdout) { | |
| process.stdout.on('data', chunk => { | |
| if (chunk instanceof Buffer) { | |
| stdout.push(chunk) | |
| } else { | |
| stdout.push(Buffer.from(chunk)) | |
| } | |
| }) | |
| } | |
| process.stdout?.on('data', chunk => { | |
| if (chunk instanceof Buffer) { | |
| stdout.push(chunk) | |
| } else { | |
| stdout.push(Buffer.from(chunk)) | |
| } | |
| }) |
There was a problem hiding this comment.
Not yet, the version of prettier that we use in dugite didn't support which is why I did it this way (sorry, should have made a comment or at least a review comment about it) it but I'm planning on bumping prettier in a separate PR (this one got noisy enough)
Co-authored-by: Sergio Padrino <sergio.padrino@gmail.com>
|
@sergiou87 Would you like me to do a prettier PR targeting this or are you happy to approve this as-is? |
Oh no worries, I got distracted away from it anyway. I should have requested a re-review. Thanks for taking a look! |
Time to give some maintenance love to dugite.
gotdependency in favor of built-in https modulechecksumdependency in favor of built-in crypto modulerimrafdependency in favor of built-in recursive remove