Fix some typing issues related to TS 4.8 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
commented
Aug 12, 2022
| @@ -34,7 +34,7 @@ export interface IGitSpawnExecutionOptions { | |||
| * set as environment variables before executing the git | |||
| * process. | |||
| */ | |||
| readonly env?: Object | |||
| readonly env?: object | |||
There was a problem hiding this comment.
object is the correct type to use 99% of the time; using Object creates problems because e.g. a deep-partial regular object can't be an Object but is a valid object.
RyanCavanaugh
commented
Aug 12, 2022
| @@ -195,7 +195,7 @@ describe('git-process', () => { | |||
| try { | |||
| await GitProcess.exec(['show', 'HEAD'], testRepoPath) | |||
| } catch (e) { | |||
| error = e | |||
| error = e as Error | |||
There was a problem hiding this comment.
In 4.8, e has type unknown under --strict. I added the one type assertion instead of turning that off
niik
approved these changes
Aug 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comments inline