Merge pull request #496 from desktop/node14

Require Node 14
desktop · Sep 5, 2022 · 8b3ece3 · 8b3ece3
2 parents fb4b92a + e602d0c
commit 8b3ece3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        nodeVersion: [12, 14, 16, 18]
+        nodeVersion: [14, 16, 18]
         arch: [x64]
         os: [macos-11, windows-2019, ubuntu-22.04]
         include:

diff --git a/package.json b/package.json
@@ -20,7 +20,7 @@
     "update-embedded-git": "node ./script/update-embedded-git.js"
   },
   "engines": {
-    "node": ">= 12"
+    "node": ">= 14"
   },
   "repository": {
     "type": "git",

diff --git a/script/download-git.js b/script/download-git.js
@@ -4,7 +4,7 @@ const ProgressBar = require('progress')
 const tar = require('tar')
 const https = require('https')
 const { createHash } = require('crypto')
-const { rm, rmdir, mkdir, createReadStream, createWriteStream, existsSync } = require('fs')
+const { rm, mkdir, createReadStream, createWriteStream, existsSync } = require('fs')
 
 const config = require('./config')()
 
@@ -101,8 +101,7 @@ if (config.source === '') {
   process.exit(0)
 }
 
-// Node 12 didn't have rm, only rmdir
-;(rm || rmdir)(config.outputPath, { recursive: true, force: true }, error => {
+rm(config.outputPath, { recursive: true, force: true }, error => {
   if (error) {
     console.log(`Unable to clean directory at ${config.outputPath}`, error)
     process.exit(1)