Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
isLRG_colorcuts
instead ofisLRG
when applying cuts to mock spectra (Similar to use isLRG_colors for color-cuts desisim#246)Smaller but important changes to get things back into a working state:
desitarget.mock.io
(see Questions/suggestions for logging module desiutil#66 for a longer-term cleanup of this type of problem)
x[col][:] = values
instead ofx[col] = values
which changes the dtype starting with astropy 1.3, resulting in output files having different formats (e.g. S10 vs. S13) for different pixels.