Fix test failures #214
Merged
Fix test failures #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there was a bug in desispec installation of data/ccd/ccd_calibration.yaml . I think I've fixed that in desispec master; testing here. If this works I'll update the desispec tag, make this branch of desisim depend on that tag, and try again... i.e. comments welcome but don't merge this just yet |
|
I tested and verified that all tests now pass, so I'm merging. Note for the future: I was getting many failures on my laptop when testing but it turns out that I had version 1.3.0 of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of test failures had crept into desisim mostly due to non-backwards compatible changes in other packages. These went unnoticed in desisim since the Travis tests were pinned to older versions. These changes get desisim back into compatibility with the latest versions of desispec, desitarget, and specter.
desisim itself will be ready for a fresh tag after confirming that these tests pass on Travis and merging.