support DA and DB white dwarf subtypes #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because the tests are using the |
|
Tests pass on my laptop but Travis seems to be having problems... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #200 (and a need of desihub/desitarget#136) to support DB- and DA-type white dwarfs via a
subtypeoptional input string to theWDclass. As requested by @sbailey in #200, the subtype is also written to the output metadata table, which allows us to potentially expand this column to include other finer-grain properties of the various templates (see also the discussion in desihub/desitarget#149). I also added a couple basic unit tests.