fixup! feat(api): disallow changing NS records under .dedyn.io

desec-io · Feb 5, 2025 · 2e63541 · 2e63541
1 parent e6cba2b
commit 2e63541
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/api/desecapi/tests/base.py b/api/desecapi/tests/base.py
@@ -1343,10 +1343,9 @@ def _test_rr_sets(cls, subname=None, type_=None, records=None, ttl=None):
 
     def setUp(self):
         super().setUp()
-        # TODO this test does not cover "dyn" / auto delegation domains
-        domain_kwargs = {"suffix": self.AUTO_DELEGATION_DOMAINS if self.DYN else None}
-        self.my_empty_domain = self.create_domain(owner=self.owner, **domain_kwargs)
-        self.my_rr_set_domain = self.create_domain(owner=self.owner, **domain_kwargs)
+        suffix = self.AUTO_DELEGATION_DOMAINS if self.DYN else None
+        self.my_empty_domain = self.create_domain(owner=self.owner, suffix=suffix)
+        self.my_rr_set_domain = self.create_domain(owner=self.owner, suffix=suffix)
         self.other_rr_set_domain = self.create_domain(suffix="")
         for domain in [self.my_rr_set_domain, self.other_rr_set_domain]:
             for subname, type_, records, ttl in self._test_rr_sets():