Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashes Barman::ServerName type #5

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

shamil
Copy link

@shamil shamil commented Aug 17, 2023

I think allowing - in server name is legit.
Also, question regarding $description option for the below, requires to be of type Barman::ServerName, which limits what can be put as description. I think description should have be allowed a free text, with spaces, etc ...

Barman::ServerName $description = $name,
and
Barman::ServerName $description = $name,

I can add a change that allows to have more permissive $description, lmk.

@deric
Copy link
Owner

deric commented Aug 18, 2023

You're right the types are too restrictive. $description should be just String. Thanks for the PR!

@deric deric merged commit 51b3b77 into deric:master Aug 18, 2023
@shamil shamil deleted the servern_name_dash branch August 18, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants