Allow dashes Barman::ServerName type #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think allowing
-
in server name is legit.Also, question regarding
$description
option for the below, requires to be of typeBarman::ServerName
, which limits what can be put as description. I think description should have be allowed a free text, with spaces, etc ...puppet-barman/manifests/postgres.pp
Line 250 in 89869bc
puppet-barman/manifests/server.pp
Line 201 in 89869bc
I can add a change that allows to have more permissive
$description
, lmk.