Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"options: - from" is being ignored #72

Closed
ypismerov opened this issue Jan 29, 2017 · 8 comments
Closed

"options: - from" is being ignored #72

ypismerov opened this issue Jan 29, 2017 · 8 comments
Labels
Milestone

Comments

@ypismerov
Copy link

I am not sure what I might be doing wrong, but from= never appears in the public key entry.
I have not tried other options though.

@deric
Copy link
Owner

deric commented Jan 30, 2017

Could you post your configuration and full debug log? e.g.:

puppet agent -t -d

@ypismerov
Copy link
Author

ypismerov commented Jan 30, 2017 via email

@deric
Copy link
Owner

deric commented Jan 30, 2017

Indentation shouldn't be a problem, it seems to be a valid YAML. Just to be sure, you can try to write it this way:

      options: [ 'from="<redacted>"' ]

Which version of puppet agent do you use? It is also puppet 3.6?

deric added a commit that referenced this issue Jan 30, 2017
@ypismerov
Copy link
Author

ypismerov commented Jan 30, 2017 via email

@deric
Copy link
Owner

deric commented Jan 30, 2017

It seems to be working on CentOS 7:

centos7-3.8 16:42:45$ /bin/sh -c cat\ /home/george/.ssh/authorized_keys
  # HEADER: This file was autogenerated at 2017-01-30 16:42:44 +0000
  # HEADER: by puppet.  While it can still be managed manually, it
  # HEADER: is definitely not recommended.
  # NOTE: This file was autogenerated by Puppet
  ssh-dss AAAAB2...19Q== george@example.net_ssh-dss
  from="*.sales.example.net,!pc.sales.example.net",permitopen="192.0.2.1:80" ssh-dss AAAAB2...19Q== george@example.net

though the key shouldn't be there twice. The configuration is following. I not sure what could be different in your environment.

@ypismerov
Copy link
Author

ypismerov commented Feb 1, 2017 via email

@deric
Copy link
Owner

deric commented Feb 6, 2017

Currently I see there multiple problems. In certain situations we bypass using ssh_authorized_key because it's on supported on older Puppet versions. Instead a template is used, which didn't support options attribute (should be fixed by fd44d3a).
The other problem is, that this template fallback is used in situations when it's not necessary (basically we're writing authorized_keys file twice, see #70).

@deric deric added bug and removed needs info labels Feb 6, 2017
@deric deric added this to the 1.6 milestone Feb 6, 2017
@deric
Copy link
Owner

deric commented May 19, 2017

Released in v1.5.3. Please reopen if the problem persists.

@deric deric closed this as completed May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants