Create UIKit app fixture #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ureKeys` framework using `Firebase`
derian-cordoba
commented
Feb 24, 2025
| <key>IS_SIGNIN_ENABLED</key> | ||
| <true></true> | ||
| </dict> | ||
| </plist> |
There was a problem hiding this comment.
FYI
The extra line is removed by the IDE auto-save formatter.
santelizvargas
approved these changes
Feb 24, 2025
|
|
||
| // Configure the Firebase service with the firebase api key confirgured | ||
| // in the SecureKeys framework | ||
| if let plistFile = Bundle.main.path(forResource: "GoogleService-Info", |
There was a problem hiding this comment.
We could move this config in other class
There was a problem hiding this comment.
@santelizvargas I think that for this example, we don't need anything too elaborate beyond the initial configuration, people can choose to do their own refactoring if they see it necessary.
There was a problem hiding this comment.
Also, I prefer to leave the project complete in order to correctly simulate the objective of a fixture.
Jcat1914
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR created the
fixturesconcept to add demo apps for people using theSecureKeysframework.Medias (if needed)
Testplan
Checklist