Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][TASK] Rename and refactor FluidStandaloneService #1269

Closed
derhansen opened this issue Sep 25, 2024 · 0 comments
Closed

[!!!][TASK] Rename and refactor FluidStandaloneService #1269

derhansen opened this issue Sep 25, 2024 · 0 comments
Assignees

Comments

@derhansen
Copy link
Owner

derhansen commented Sep 25, 2024

The service must be renamed, as StandaloneView in core is deprecated and the service basically renders a given template or a given string.

See https://review.typo3.org/c/Packages/TYPO3.CMS/+/85735

Huge change with a lot of refactoring required. Best is, to hand over the PSR-7 Request to NotificationService in methods, so this can be used in FluidStandaloneView (which must be renamed).

@derhansen derhansen added this to the 8.0.0 - TYPO3 v13 milestone Sep 25, 2024
@derhansen derhansen self-assigned this Sep 25, 2024
@derhansen derhansen changed the title [!!!][TASK] Rename FluidStandaloneService [!!!][TASK] Rename and refactor FluidStandaloneService Sep 27, 2024
derhansen added a commit that referenced this issue Sep 27, 2024
With this change, the `FluidStandaloneService` has been renamed to
`FluidRenderingService`. Additionally, the method arguments of
`getTemplateFolders()` has changed, so the arguments `$extensionName`
and `$pluginName` have been removed.

The service now does not rely on `StandaloneView` any more, which
has been deprecated with TYPO3 v13. Instead, the service now uses
Fluid `ViewFactory` for view rendering.

Finally, all mocked unit tests have been refactored to functional
tests.

Closes #1269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant