[Mellanox] Add new CLI commands to support TXMON feature #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @click.pass_context | ||
| @click.argument('interface_name', metavar='<interface_name>', required=True) | ||
| @click.argument('tx_thresh', metavar='<tx_thresh>', required=True, type=int) | ||
| def set(ctx, interface_name, tx_thresh): |
There was a problem hiding this comment.
please also verify the "tx_thresh" is bigger than 0.
| # 'period' command ('config txmon period ...') | ||
| # | ||
| @txmon.command('period', short_help="Set global period interval (seconds) for Tx Monitor") | ||
| @click.argument('interval', metavar='<interval>', required=True, type=int) |
There was a problem hiding this comment.
please also verify the "interval" is bigger than 0.
|
|
||
| state_db = SonicV2Connector(host='127.0.0.1') | ||
| state_db.connect(state_db.STATE_DB, False) # Make one attempt only | ||
| TABLE_NAME_SEPARATOR = '|' |
| @@ -2001,6 +2001,63 @@ def shutdown(ctx, interface_name): | |||
| else: | |||
| config_db.mod_entry("PORTCHANNEL", interface_name, {"admin_status": "down"}) | |||
|
|
|||
| # | |||
There was a problem hiding this comment.
Usually when we add a new CLI command in SONiC we don't mix other existing commands with new options.
A correct implementation will be:
- config txmon set Ethernet# 10
- config txmon clear Ethernet#
- config txmon period 10
- config txmon state enable/disable
| @@ -668,6 +668,48 @@ def alias(interfacename): | |||
| body.append([port_name, port_name]) | |||
|
|
|||
| click.echo(tabulate(body, header)) | |||
|
|
|||
There was a problem hiding this comment.
Same comment here as in 'config'
A correct implementation can be:
- show txmon status
To show the current interval and then a table of all configured interfaces.
or
- show txmon interval
- show txmon interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added new CLI commands to support TXMON (LAB 5 ) feature.
2 configuration commands and 2 show commands.
- How I did it
edited show show/main.py and config config/main.py
- How to verify it
Manual testing:
config commands:
show commands:
- Previous command output (if the output of a command-line utility has changed)
NA
- New command output (if the output of a command-line utility has changed)
NA