Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix incorrect React.Fragment for ContentNode type #1521

Merged
merged 5 commits into from
Jun 12, 2024
Merged

fix(react): fix incorrect React.Fragment for ContentNode type #1521

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6b9a332
fix(react): fix incorrect React.Fragment for ContentNode type
scurker Jun 12, 2024
c3564a8
fix types
scurker Jun 12, 2024
fe25a7d
Merge branch 'develop' into fix-content-node-type
scurker Jun 12, 2024
39eafcd
fix
scurker Jun 12, 2024
bda1e3f
Merge branch 'develop' into fix-content-node-type
anastasialanz Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/react/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { ReactElement, ReactFragment, ReactPortal } from 'react';
import type { ReactElement, ReactPortal } from 'react';

// eslint-disable-next-line @typescript-eslint/no-namespace
export namespace Cauldron {
Expand All @@ -11,9 +11,4 @@ export namespace Cauldron {
* This type is meant to ensure that a prop can actually be rendered as content.
* Explicit equivalent of Exclude<ReactNode, boolean | null | undefined>
*/
export type ContentNode =
| string
| number
| ReactFragment
| ReactPortal
| ReactElement;
export type ContentNode = string | number | ReactPortal | ReactElement;
Loading