Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: switch nav bar tests to react testing library #1403

Merged
merged 6 commits into from
Apr 30, 2024
Merged

test: switch nav bar tests to react testing library #1403

merged 6 commits into from
Apr 30, 2024

Conversation

lsprr
Copy link
Contributor

@lsprr lsprr commented Mar 9, 2024

Issue #1159

This PR switches the Nav Bar tests to React Testing Library.

Validation steps

  • Run yarn test
  • See that there are coverage percentages in the table
  • Verify that the tests are converted properly

@lsprr lsprr requested a review from a team as a code owner March 9, 2024 01:22
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1403.d15792l1n26ww3.amplifyapp.com

scurker
scurker requested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm so far behind on these, but thank you again for your contribution! Just one small change needed here to test for an additional a11y state.

packages/react/src/components/NavBar/navBar.test.tsx Outdated Show resolved Hide resolved
@scurker
Copy link
Member

scurker commented Apr 30, 2024

🚨 Reviewed for Security 🚨

@scurker scurker merged commit 6aa6d6d into dequelabs:develop Apr 30, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsprr @scurker