Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: switch table tests to react testing library #1374

Merged
merged 7 commits into from
Mar 19, 2024
Merged

test: switch table tests to react testing library #1374

merged 7 commits into from
Mar 19, 2024

Conversation

lsprr
Copy link
Contributor

@lsprr lsprr commented Mar 1, 2024 •
edited
Loading

Issue #1159

This PR switches the Table tests to React Testing Library.

Validation steps

  • Run yarn test
  • See that there are coverage percentages in the table
  • Verify that the tests are converted properly

@lsprr lsprr requested a review from a team as a code owner March 1, 2024 00:28
@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1374.d15792l1n26ww3.amplifyapp.com

scurker
scurker requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few minor things to change.

packages/react/src/components/Table/index.test.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Table/index.test.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Table/index.test.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Table/index.test.tsx Outdated Show resolved Hide resolved
packages/react/src/components/Table/index.test.tsx Show resolved Hide resolved
scurker
scurker approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Reviewed for Security 🚨

@scurker scurker merged commit 3904980 into dequelabs:develop Mar 19, 2024
6 of 7 checks passed
@scurker scurker mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsprr @scurker