Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: switch tag tests to react testing library #1333

Merged
merged 5 commits into from
Feb 5, 2024
Merged

test: switch tag tests to react testing library #1333

merged 5 commits into from
Feb 5, 2024

Conversation

anastasialanz
Copy link
Contributor

@anastasialanz anastasialanz commented Feb 3, 2024 •
edited
Loading

Issue #1159

This PR switches the Tag tests to React Testing Library. It also corrects the paths for setupFilesAfterEnv and collectCoverageFrom in the jest.config.ts.

Validation steps

  • Run yarn test
  • See that there are coverage percentages in the table
  • Verify that the tests are converted properly

@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1333.d15792l1n26ww3.amplifyapp.com

@anastasialanz anastasialanz marked this pull request as ready for review February 4, 2024 02:19
@anastasialanz anastasialanz requested a review from a team as a code owner February 4, 2024 02:19
scurker
scurker reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@scurker scurker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, just one question on the coverage change.

packages/react/jest.config.ts Outdated Show resolved Hide resolved
@anastasialanz @scurker
Update packages/react/jest.config.ts
6b2c648 
Co-authored-by: Jason <jason@scurker.com>
@anastasialanz anastasialanz merged commit 6817bbd into develop Feb 5, 2024
6 checks passed
@anastasialanz anastasialanz deleted the tests--tag branch February 5, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scurker scurker scurker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anastasialanz @scurker