chore: upgrade babel/typescript to support latest features #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://babel-upgrade.d1gko6en628vir.amplifyapp.com |
scurker
commented
Aug 18, 2023
| @@ -128,7 +127,7 @@ | |||
| "style-loader": "^0.19.0", | |||
| "terser-webpack-plugin": "^5.3.6", | |||
| "ts-node": "^10.9.1", | |||
| "typescript": "^3.7.5", | |||
| "typescript": "~5.0.0", | |||
There was a problem hiding this comment.
prettier yells at you if it's 5.1.0 or greater 🤷
| @@ -11,7 +11,6 @@ | |||
| } | |||
| ], | |||
| "transform-export-extensions", | |||
| "@babel/plugin-proposal-class-properties", | |||
There was a problem hiding this comment.
now included as part of preset-env
| @@ -34,18 +34,15 @@ | |||
| "tslib": "^2.4.0" | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/cli": "^7.8.4", | |||
| @@ -115,7 +115,6 @@ IconButton.propTypes = { | |||
| as: PropTypes.elementType, | |||
| // @ts-expect-error | |||
| icon: PropTypes.string.isRequired, | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
apparently none of these error anymore
There was a problem hiding this comment.
The others still error?
| @@ -23,7 +23,8 @@ | |||
| "release": "./scripts/release.sh" | |||
| }, | |||
| "prettier": { | |||
| "singleQuote": true | |||
| "singleQuote": true, | |||
| "trailingComma": "none" | |||
There was a problem hiding this comment.
I don't really care that much, but this keeps the existing behavior that was present before the upgrade to keep things consistent
scurker
commented
Aug 18, 2023
| "@babel/plugin-proposal-export-default-from": "^7.2.0", | ||
| "@babel/preset-env": "^7.8.4", | ||
| "@babel/preset-react": "^7.0.0", | ||
| "@babel/preset-stage-0": "^7.0.0", |
There was a problem hiding this comment.
not really needed anymore
|
Looks good to me! |
dequejosie
approved these changes
Aug 18, 2023
|
Preview branch generated at https://babel-upgrade.d1gko6en628vir.amplifyapp.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General cleanup of typescript/babel dependencies. Removed a few unused babel plugins, but there were some issues with
import type...on #1167 that I was trying to resolve here separately.