fix node4 build issue #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2017 11:27
Block-scoped declarations (let, const, function, class) not yet supported outside strict mode
provides minimal requirements warning
|
|
marcysutton
approved these changes
Sep 20, 2017
| @@ -3,6 +3,9 @@ | |||
| "description": "Accessibility engine for automated Web UI testing", | |||
| "version": "3.0.0-alpha.4", | |||
| "license": "MPL-2.0", | |||
| "engines": { | |||
| "node": ">=4" | |||
There was a problem hiding this comment.
Do we need to specify a node version if we're downgrading it to use var?
There was a problem hiding this comment.
it just produces a warning for anybody running on older versions, so it's useful
|
Maybe also add supported node version to test to catch these issues in the future: |
|
@renatoi our tests running on Circle have different requirements than axe-core for end-users. We transpile lib JS using Babel for backwards-compatibility but this isn't required for our tests. The postinstall script wasn't caught by Babel unfortunately. |
marcysutton
pushed a commit
that referenced
this pull request
Sep 21, 2017
* fix(node4): use var to declare variables Block-scoped declarations (let, const, function, class) not yet supported outside strict mode * feat(package): add engine hint to package.json provides minimal requirements warning
marcysutton
pushed a commit
that referenced
this pull request
Dec 11, 2017
* fix(node4): use var to declare variables Block-scoped declarations (let, const, function, class) not yet supported outside strict mode * feat(package): add engine hint to package.json provides minimal requirements warning
marcysutton
pushed a commit
that referenced
this pull request
Dec 12, 2017
* fix(node4): use var to declare variables Block-scoped declarations (let, const, function, class) not yet supported outside strict mode * feat(package): add engine hint to package.json provides minimal requirements warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #541