Aria 1.1. tests #509
Merged
Aria 1.1. tests #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably a dumb question, but what IDs these as 1.1 tests vs 1.2? |
WilcoFiers
approved these changes
Sep 6, 2017
marcysutton
added a commit
that referenced
this pull request
Sep 6, 2017
* feat(ARIA 1.1): Allow row-index, setsize and posinset on more roles * test(aria): aria-haspopup, aria-modal for 1.1 * style(test/aria): add line breaks for readability * test(aria): add missing roles and properties
|
@marcysutton thanks for the explanation. I was thinking more back to the Quail days where rulesets were strongly typed |
mrtnvh
pushed a commit
to mrtnvh/axe-core
that referenced
this pull request
Nov 24, 2023
* chore: update webdriverio peerDependency We believe the issue that caused us to pin to 7.14.1 was this one webdriverio/webdriverio#7994. Testing versions of webdriverio 7.14 - 7.19 no longer causes us any issues. The issue seems to have been resolved and we no longer need to pin to a specific version. * update version * regenerate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully I got them all! I didn't see a way to test the owned/context changes for treegrid in https://github.com/dequelabs/axe-core/pull/479/files.
Also, we should really find a way to replace the hard-coded IDs in those integration test files. Couldn't we generate those with JS? Reordering them is such a huge pain.