fix(color-contrast): correctly apply page background color #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…core into visually-contains
WilcoFiers
approved these changes
Oct 13, 2021
straker
added a commit
that referenced
this pull request
Oct 18, 2021
* fixes * finalize * sort * test * fix tests * Update lib/commons/color/get-background-stack.js Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com> * fixes * fix(color-contrast): correctly apply page background color Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
This was referenced Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, spitting #3203 into two separate prs.
I modified how the body bgColor is added to the
get-background-colorelement stack. How body and html affect the background is a bit complex, so it was better to not add body any time (get-background-stack.js => sortPageBackground) was missing but to instead grab either the html or body colors as they correctly applied. It turns out that defining a bg color to the html element allowed negative z-index elements to go behind the body, so I also took that into account.For some examples!
Using the following code:
#targetis outside body#targetis inside body#targethasz-index=-1#targethasz-index=-1I added new tests for all these cases so we should accurately get the background color (and apply z-index correctly).
Closes issue: #2218