Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): allow passing a NodeList to ElementContext #3161

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

kaelig
Copy link
Contributor

@kaelig kaelig commented Sep 22, 2021

As per the spec, the context parameter can be passed one of the following:

A NodeList such as returned by document.querySelectorAll.

Source: https://www.deque.com/axe/core-documentation/api-documentation/#context-parameter

As per the spec, the context parameter can be passed one of the following:

> A `NodeList` such as returned by `document.querySelectorAll`.

Source: https://www.deque.com/axe/core-documentation/api-documentation/#context-parameter
@kaelig kaelig requested a review from a team as a code owner September 22, 2021 17:23
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr

@straker straker changed the title Allow passing a NodeList to ElementContext fix(typescript): allow passing a NodeList to ElementContext Sep 27, 2021
@straker
Copy link
Contributor

straker commented Sep 27, 2021

Reviewed for security

@straker straker merged commit ad4b165 into dequelabs:develop Sep 27, 2021
@kaelig kaelig deleted the patch-1 branch September 27, 2021 17:11
straker pushed a commit that referenced this pull request Oct 18, 2021
As per the spec, the context parameter can be passed one of the following:

> A `NodeList` such as returned by `document.querySelectorAll`.

Source: https://www.deque.com/axe/core-documentation/api-documentation/#context-parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants