fix(aria-allowed-role): Update allowed roles based on ARIA spec updates #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timogasda Thank you for the PR! We were actually working on this too, but got a little side tracked. @straker will be reviewing this. |
|
Nice! Could you also add |
* `<b>` now allows any roles * `<nav>` now also allows `menu`, `menubar`, `tablist` * `<svg>` now allows any roles Based on ARIA spec: https://www.w3.org/TR/html-aria/
7270d92 to
50892ce
Compare
|
@straker Of course, done! |
straker
approved these changes
Aug 13, 2021
|
There's currently an issue with our CircleCI config that doesn't allow the test scripts to run from outside contributors. The only work around we've found so far is for us to create a new branch and then cherry-pick your changes into it and open a new pr. I'm going to do that and then close this pr. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating some of the allowed role rules to reflect the latest changes to the ARIA spec.
<b>now allows any roles<nav>now also allowsmenu,menubar,tablist<svg>now allows any rolesBased on ARIA spec: https://www.w3.org/TR/html-aria/
Closes issue: #3082