fix(color-contrast-matches): only absolutely positioned elements using clip should be not visible #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Jun 28, 2021
| @@ -174,6 +188,21 @@ describe('dom.isVisible', function() { | |||
| assert.isFalse(axe.commons.dom.isVisible(el)); | |||
| }); | |||
|
|
|||
| it('should detect when clip is not applied because of positioning on parent', function() { | |||
There was a problem hiding this comment.
Why are you repeating tests?
There was a problem hiding this comment.
I'm not - this is when clip is not applied because of positioning on the parent, the previous test is positioning on the element itself. Down below, it's testing when the screenreader option is set using these same two cases.
WilcoFiers
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clip is only applied on absolutely positioned elements (
position: fixedorposition: absolute), so if an element is usingclipbut doesn't have that positioning, it will still be visible.Closes issue: #3037