fix(combobox): support aria 1.2 pattern for comboboxes #3033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
reviewed
Jun 23, 2021
lib/standards/aria-roles.js
Outdated
| @@ -117,8 +117,8 @@ const ariaRoles = { | |||
| }, | |||
| combobox: { | |||
| type: 'composite', | |||
| requiredOwned: ['listbox', 'tree', 'grid', 'dialog', 'textbox'], | |||
| requiredAttrs: ['aria-expanded'], | |||
| requiredOwned: ['listbox', 'tree', 'grid', 'dialog'], | |||
There was a problem hiding this comment.
From #2505 (comment)
It seems like if axe removed the aria-required-children for combobox entirely
Suggested change
| requiredOwned: ['listbox', 'tree', 'grid', 'dialog'], |
lib/standards/aria-roles.js
Outdated
| requiredOwned: ['listbox', 'tree', 'grid', 'dialog', 'textbox'], | ||
| requiredAttrs: ['aria-expanded'], | ||
| requiredOwned: ['listbox', 'tree', 'grid', 'dialog'], | ||
| requiredAttrs: ['aria-expanded', 'aria-controls', 'aria-owns'], |
There was a problem hiding this comment.
This implies that both are required when in reality it's just one or the other. That's not something we can support, so maybe we just list the 1.2 spec required attrs and then special case aria-owns to support the 1.0/1 pattern in aria-required-attrs-evaluate.
Also add aria-owns to the allowedAttrs array and remove aria-controls from it (since it's now in the required array).
Suggested change
| requiredAttrs: ['aria-expanded', 'aria-controls', 'aria-owns'], | |
| requiredAttrs: ['aria-expanded', 'aria-controls'], |
straker
previously requested changes
Jun 29, 2021
| @@ -28,7 +28,14 @@ | |||
| ok | |||
| </div> | |||
| <div role="heading" id="pass4" aria-level="1">ok</div> | |||
| <div role="combobox" id="pass5" aria-expanded="true">ok</div> | |||
| <div | |||
There was a problem hiding this comment.
Should add another comobox that uses the aria-owned pattern as well
straker
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #2505