feat: Support multiple languages at once in builds #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
approved these changes
Jun 15, 2021
clottman
added a commit
that referenced
this pull request
Jun 17, 2021
* aria-supported doesn't throw if multiple languages used * include info on targeting multiple languages in readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the code for this was already in place; only the aria-supported task was failing when you tried to enter multiple languages to build for. It doesn't seem like that task actually does anything different depending on the language, so this code uses the first language of the languages that were entered (if any) to find the right axe.**.js file to use to generate aria-supported.md.
Closes issue #2714