Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rule): add ACT Rule IDs to test rule objects #2866

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

rweberkaf
Copy link
Contributor

Add new property actIds to axe-core rule objects and populate with ACT Rule IDs; update validation schema to permit them. Link to corresponding ACT description pages in rule-descriptions.md.

Closes issue: #2820

@rweberkaf rweberkaf requested a review from a team as a code owner April 6, 2021 20:30
@WilcoFiers WilcoFiers self-assigned this Apr 7, 2021
@straker
Copy link
Contributor

straker commented Apr 13, 2021

Thank you for the pr. @WilcoFiers will need to look over it, but we've been super busy preparing for the 4.2 release coming in the next few weeks. I'm not sure this pr will get in before the release so it might be a bit before he can get to it.

@WilcoFiers
Copy link
Contributor

@rweberkaf Just to update you on this. This PR in came in just a little too late to make it into the 4.2 release. We'll pull this in after 4.2 is released. Some time next week I imagine.

WilcoFiers
WilcoFiers previously approved these changes Apr 22, 2021
@WilcoFiers
Copy link
Contributor

@rweberkaf can you merge develop back into your branch. To resolve the merge conflict, best to just rerun grunt build. It'll create a new version of the file that's conflicting now.

@rweberkaf
Copy link
Contributor Author

All set, @WilcoFiers , thank you!

@WilcoFiers
Copy link
Contributor

Thank you for the contribution @rweberkaf! It is very much appreciated.

@WilcoFiers
Copy link
Contributor

And for the record, I reviewed this PR for security.

@WilcoFiers WilcoFiers merged commit cc1ebf5 into dequelabs:develop Apr 28, 2021
@straker straker added docs Documentation changes pr A pr has been created for the issue and removed docs Documentation changes pr A pr has been created for the issue labels Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants