-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule): add ACT Rule IDs to test rule objects #2866
Conversation
Thank you for the pr. @WilcoFiers will need to look over it, but we've been super busy preparing for the 4.2 release coming in the next few weeks. I'm not sure this pr will get in before the release so it might be a bit before he can get to it. |
@rweberkaf Just to update you on this. This PR in came in just a little too late to make it into the 4.2 release. We'll pull this in after 4.2 is released. Some time next week I imagine. |
@rweberkaf can you merge develop back into your branch. To resolve the merge conflict, best to just rerun |
All set, @WilcoFiers , thank you! |
Thank you for the contribution @rweberkaf! It is very much appreciated. |
And for the record, I reviewed this PR for security. |
Add new property
actIds
to axe-core rule objects and populate with ACT Rule IDs; update validation schema to permit them. Link to corresponding ACT description pages inrule-descriptions.md
.Closes issue: #2820