Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.1.2 #2792

Merged
merged 5 commits into from
Feb 9, 2021
Merged

Release 4.1.2 #2792

merged 5 commits into from
Feb 9, 2021

Conversation

straker
Copy link
Contributor

@straker straker commented Feb 8, 2021

No description provided.

straker and others added 4 commits February 8, 2021 10:16
@straker @WilcoFiers @stephenmathieson
fix: add noHtml to axe.configure (#2789)
6e23eb0 
* fix: add noHtml to axe.configure

* docs

* Update lib/core/utils/dq-element.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update lib/core/utils/dq-element.js

Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>

* tests

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Stephen Mathieson <me@stephenmathieson.com>
@straker
fix tests
1526495
@straker
fix: do not allow postMessage with axe version of x.y.z (#2790)
8b1671d
@straker
fix tests
8c83859
@straker straker requested a review from a team as a code owner February 8, 2021 19:02
@straker
Copy link
Contributor Author

straker commented Feb 8, 2021

Please don't merge this just yet. We had a request to talk about it tomorrow.

@stephenmathieson
Copy link
Member

Do we now need to update the tests for every release?

@straker
Copy link
Contributor Author

straker commented Feb 8, 2021

No. When we merge the Karma changes none of these changes will need to happen. It's just for whatever reason the old way of our test framework is causing issues

WilcoFiers
WilcoFiers previously approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release Audit

@WilcoFiers WilcoFiers merged commit 11a514d into master Feb 9, 2021
@WilcoFiers WilcoFiers deleted the release-4.1.2 branch February 9, 2021 10:02
@keith-rhodes-0723
Copy link
Contributor

Reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@straker @stephenmathieson @keith-rhodes-0723 @WilcoFiers