-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): missing translations for DE #2704
Conversation
Thanks for the updated translations. We're looking for someone internally who can speak German to verify the additions. It might take awhile with the Christmas holiday coming up but we'll get it merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please se the comments for changes and discussions
Today I compared the already translated entries with a freshly generated file and saw that many |
Good question that @WilcoFiers or @straker can probably answer better than I can |
@Cerberooo Correct. An empty string will be treated as a non-existent translation and axe will fill in the translation with the English version. Preferably we'd like all the translation strings to be filled in. |
@dylanb If you like you can take a look at the newly added strings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One spelling mistake and the usage of Zugänglichkeit-Objekt des Elements
should be reversed
@straker I think it's ready to go! |
Reviewed for security. Thanks so much for putting this together! |
Maybe requires proofreading here & there.