fix(region): allow role=dialog and svg elements outside regions #2586
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking into how our region rule was passing a test for
role=dialog
when an issue said it wasn't. Turns out our test wasn't written correctly so even though the code should have been failing it wasn't. I made sure to edit all the tests to ensure they work as expected and added a note at the top of the file on how to properly add a new test fixture.I also removed the form with title test since with 4.0 it is no longer considered a landmark and also suffered from the same problem as the dialog test.
Lastly, our code already supported a
regionMatcher
option so I just made sure to provide defaults for dialog and svg.Closes issue: #1832 and #2556
Reviewer checks
Required fields, to be filled out by PR reviewer(s)