fix(heading-order): evaluate headings from iframes in DOM order #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously approved these changes
Oct 21, 2020
dylanb
reviewed
Oct 21, 2020
| ["#heading7"], | ||
| ["#heading8"], | ||
| ["#heading9"], | ||
| ["#heading10"], |
There was a problem hiding this comment.
#heading10 should come after the frame
There was a problem hiding this comment.
The test results aren't ordered. Nevertheless, probably good to put them in order.
WilcoFiers
reviewed
Oct 21, 2020
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
previously approved these changes
Oct 21, 2020
WilcoFiers
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this changes the selectors returned by axe as iframe results are now in DOM order so the first node encountered could be an iframe element rather than the top-level element.
Closes issue: #2561
Reviewer checks
Required fields, to be filled out by PR reviewer(s)