feat(checks): deprecate role-none and role-presentation for presentational-role #2503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
commented
Sep 1, 2020
| @@ -87,6 +87,7 @@ function buildRules(grunt, options, commons, callback) { | |||
| var tags = options.tags ? options.tags.split(/\s*,\s*/) : []; | |||
| var rules = result.rules; | |||
| var checks = result.checks; | |||
| parseChecks(checks); | |||
There was a problem hiding this comment.
From the code, a check's metatdata was only added to axe._load if a rule used it. Since role-none and role-presentation were no longer used in any rule, their metadata was never added. This caused any translation file that passed translations for those checks to fail axe.configure with
"Locale provided for unknown check: "role-none""
To fix I added this line to parse all checks regardless of if a rule uses it or not.
WilcoFiers
previously requested changes
Sep 2, 2020
Comment on lines
+36
to
+41
| <iframe | ||
| src="frame-title/frames/level1a.html" | ||
| id="violation4" | ||
| role="none" | ||
| aria-live="assertive" | ||
| ></iframe> |
There was a problem hiding this comment.
We may have to do more work for iframes here later. I don't think this is correct, but we'll get to it when Jey finishes his work on iframes in ACT. Acceptable for now.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
presentational-rolecheck is written in such a way that as long as the end role of the element is presentation/none the check will pass. This enables it to be used for things that don't use explicit role to make it presentation, such as an images emptyaltattribute. That should help when fixing #2502 so we don't have to check the role in that check.Also, I removed the presentational check on the
link-namerule as there is no way to disable a link from being focusable without a) making it hidden which prevents the rule from running on it or b) removing thehrefattribute which goes against theselectorof the rule.Closes issue: #2454
Reviewer checks
Required fields, to be filled out by PR reviewer(s)